fix discord experiments setting and move it to the Advanced settings tab

renderer/src/builtins/settings/components/Advanced.jsx

@@ -1,13 +1,15 @@
 import { SwitchItem } from '@vizality/components/settings';
 import React, { memo, useEffect } from 'react';
+import { getModule } from '@vizality/webpack';
 import { useFilter } from '@vizality/hooks';
 import { Messages } from '@vizality/i18n';
 
 export default memo(({ builtin, search = '' }) => {
+  const [ experimentalWebPlatform, setExperimentalWebPlatform ] = vizality.api.settings.useSetting('experimentalWebPlatform', false);
+  const [ discordExperiments, setDiscordExperiments ] = vizality.api.settings.useSetting('discordExperiments', false);
   const [ smoothScrolling, setSmoothScrolling ] = vizality.api.settings.useSetting('smoothScrolling', true);
   const [ debugLogs, setDebugLogs ] = vizality.api.settings.useSetting('debugLogs', false);
   const [ hideToken, setHideToken ] = vizality.api.settings.useSetting('hideToken', true);
-  const [ experimentalWebPlatform, setExperimentalWebPlatform ] = vizality.api.settings.useSetting('experimentalWebPlatform', false);
 
   const items = [
     {
@@ -73,6 +75,31 @@ export default memo(({ builtin, search = '' }) => {
         >
           {Messages.VIZALITY_SETTINGS_EXP_WEB_PLATFORM}
         </SwitchItem>
+    },
+    {
+      search: [
+        Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS,
+        Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS_DESC.format()
+      ],
+      render: query =>
+        <SwitchItem
+          description={Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS_DESC.format()}
+          value={discordExperiments}
+          onChange={() => {
+            try {
+              setDiscordExperiments(!discordExperiments);
+              const experimentsModule = getModule(r => r.isDeveloper !== void 0);
+              Object.defineProperty(experimentsModule, 'isDeveloper', {
+                get: () => !discordExperiments,
+                configurable: true
+              });
+            } catch (err) {
+              console.warn(err);
+            }
+          }}
+        >
+          {Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS}
+        </SwitchItem>
     }
   ];
 

renderer/src/builtins/settings/components/Developer.jsx

@@ -1,13 +1,11 @@
 import { SwitchItem } from '@vizality/components/settings';
 import React, { memo, useEffect } from 'react';
-import { getModule } from '@vizality/webpack';
 import { useFilter } from '@vizality/hooks';
 import { Messages } from '@vizality/i18n';
 
 export default memo(({ builtin, search = '' }) => {
   const [ reactDeveloperTools, setReactDeveloperTools ] = vizality.api.settings.useSetting('reactDeveloperTools', false);
   const [ hotReload, setHotReload ] = vizality.api.settings.useSetting('hotReload', false);
-  const [ discordExperiments, setDiscordExperiments ] = vizality.api.settings.useSetting('discordExperiments', false);
 
   const items = [
     {
@@ -42,24 +40,6 @@ export default memo(({ builtin, search = '' }) => {
         >
           {Messages.VIZALITY_SETTINGS_PLUGIN_HOT_RELOAD}
         </SwitchItem>
-    },
-    {
-      search: [
-        Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS,
-        Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS_DESC.format()
-      ],
-      render: query =>
-        <SwitchItem
-          description={Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS_DESC.format()}
-          value={discordExperiments}
-          onChange={() => {
-            setDiscordExperiments(!discordExperiments);
-            const experimentsModule = getModule(r => r.isDeveloper !== void 0);
-            experimentsModule._changeCallbacks.forEach(cb => cb());
-          }}
-        >
-          {Messages.VIZALITY_SETTINGS_DISCORD_EXPERIMENTS}
-        </SwitchItem>
     }
   ];
 
@@ -68,9 +48,5 @@ export default memo(({ builtin, search = '' }) => {
     data: items
   });
 
-  useEffect(() => {
-    setQuery(search);
-  }, [ search ]);
-
   return filteredResults.map(result => result.render(query));
 });