winFirst: don't remake shortcuts, tweaks

src/bootstrap.js

@@ -91,7 +91,7 @@ const startUpdate = () => {
     inst.on('InconsistentInstallerState', fatal);
     inst.on('update-error', console.error);
 
-    require('./winFirst').do(inst);
+    require('./winFirst').do();
   } else {
     moduleUpdater.init(Constants.UPDATE_ENDPOINT, buildInfo);
   }

src/winFirst.js

@@ -1,15 +1,14 @@
 const fs = require('fs');
-const { join, resolve, basename } = require('path');
+const { join, resolve } = require('path');
 
 const Constants = require('./Constants');
 const reg = (a, c) => require('child_process').execFile('reg.exe', a, c);
 
 const exec = process.execPath;
 const app = resolve(exec, '..');
-const root = resolve(app, '..');
 
 
-exports.do = (updater) => {
+exports.do = () => {
   const flag = join(app, '.first-run');
   if (fs.existsSync(flag)) return; // Already done, skip
 
@@ -23,31 +22,8 @@ exports.do = (updater) => {
     [base + '\\shell\\open\\command', '/ve', '/d', `"${exec}" --url -- "%1"`]
   ]) reg([ 'add', ...x, '/f' ], e => {});
 
-  try { // Make shortcuts
-    const file = Constants.APP_NAME_FOR_HUMANS + '.lnk';
-    const icon_path = join(root, 'app.ico');
-
-    fs.copyFileSync(join(app, 'app.ico'), icon_path); // app-1.0.0/app.ico -> app.ico
-
-    for (const shortcut_path of [
-      join(updater.getKnownFolder('desktop'), file),
-      join(updater.getKnownFolder('programs'), Constants.APP_COMPANY, file)
-    ]) {
-      if (!fs.existsSync(shortcut_path)) continue; // Don't update already deleted paths
-
-      updater.createShortcut({
-        target_path: join(root, 'Update.exe'),
-        shortcut_path,
-        arguments: '--processStart ' + basename(exec),
-        icon_path,
-        icon_index: 0,
-        description: Constants.APP_DESCRIPTION,
-        app_user_model_id: Constants.APP_ID,
-        working_directory: app
-      });
-    }
-
-    fs.writeFileSync(flag, 'true');
+  try {
+    fs.writeFileSync(flag, '');
   } catch (e) {
     log('FirstRun', e);
   }